Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #697

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Fix tests #697

merged 4 commits into from
Jul 31, 2024

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Jul 30, 2024 •
edited
Loading

Fixes

error updating VM spec section: API Error: 400: [ 34132-2024-07-30-10-32-54-071--c3eec3d0-5b83-42e1-8740-d276d94841a5 ] HTTP 400 Bad Request
         - Undeclared namespace prefix "ns5" (for attribute "ipAddressingMode")
         at [row,col {unknown-source}]: [34,114]
  • Modifies Test_CreateDeleteEdgeGatewayAdvanced to avoid an odd test failure as VCD returns Connected: true when retrieving the Edge Gateway data.

Fix tests
b7f5042 
Signed-off-by: abarreiro <[email protected]>
Didainius
Didainius approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog note

@adambarreiro adambarreiro self-assigned this Jul 30, 2024
abarreiro added 2 commits July 30, 2024 16:11
Fix test
0fc7a9a 
Signed-off-by: abarreiro <[email protected]>
Changelog
42aeb33 
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro marked this pull request as ready for review July 30, 2024 14:40
@adambarreiro adambarreiro requested a review from lvirbalas as a code owner July 30, 2024 14:40
@adambarreiro adambarreiro removed the request for review from lvirbalas July 30, 2024 14:40
Changelog
4486cef 
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro merged commit 0070ee9 into vmware:main Jul 31, 2024
2 checks passed
@adambarreiro adambarreiro deleted the fix-tests branch July 31, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

Assignees

@adambarreiro adambarreiro

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adambarreiro @Didainius @vmwclabot